-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): Improve revenue information #3250
feat(frontend): Improve revenue information #3250
Conversation
Like the general idea and look, though instead of a total pending, and next pending; I think it's only possible to have 3 months with pending amounts at a time. Maybe having the amount of the 3 months (like if it's Nov 15, You have September's Revenue, October's and November's) Also the "in transit" phrase implies that it is currently in the process of it being sent, when that's not really true |
The API doesn't store time information with actual revenue data (analytics doesn't take into account Modrinth's cut/any fees, it's slightly inaccurate by $3-4) - meaning if I did display all the monthly values they'd all be estimates, not really helpful and unnecessary if we already have the accurate total pending value I think the "in transit" is perfectly acceptable as it is in a way in transit - the ad provider is currently collecting the ad budgets before sending it to Modrinth, it arrives on the date specified. I think this is the only way to keep it understandable for users whilst ensuring that a level of accuracy is kept by showing the total pending as before |
I think that maybe it'd a good idea to rename "Current Balance" to "Available to withdraw", "Pending in Transit" to "In processing" and "Pending Total" to "Awaits processing" And then switch places of Pending in Transit and Pending Total "Awaits processing" (total) could also have a hint at the bottom the same as Pending in Transit does now, saying something along the lines of "earned since Month XX, YYYY". To be accurate this would probably require subtracting the pending from the total, as far as I can tell |
I think im going to wait for a proper check from Modrinth before changing terminology, want to get it right without much bikeshedding |
I think what I have currently is perfectly acceptable honestly |
@Prospector Just wondering, what is your opinion on the wording - does it need to change? |
Yeah, definitely should not say "in transit" since that implies something entirely unrelated. The way I would phrase it is: |
Someone else would have to do that - unfortunately my rust knowledge is non-existent |
yeah, same. that the main reason I haven't overhauled this page yet |
I would be able to revisit this in a few weeks though, I am in process of learning the language |
Closing this PR to work on a version of it that does the logic in the backend |
…n' into feat/improved-pending-information
…n' into feat/improved-pending-information
Head branch was pushed to by a user without write access
This pull request improves the revenue information on the
/dashboard/revenue
page.